Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K-80: tf state file handling for multiple deployments #95

Merged
merged 10 commits into from
Feb 4, 2020

Conversation

ms-shankar
Copy link
Contributor

@ms-shankar ms-shankar commented Dec 11, 2019

Description

Closes #29, #80, #99 #102 and #105

Checklist

  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ms-shankar ms-shankar changed the title [WIP] K-XXX tf state file handling for multiple deployments K-80 tf state file handling for multiple deployments Jan 20, 2020
@ms-shankar ms-shankar changed the title K-80 tf state file handling for multiple deployments K-80 tf state file handling for multiple deployments Jan 20, 2020
@ms-shankar ms-shankar changed the title K-80 tf state file handling for multiple deployments K-80: tf state file handling for multiple deployments Jan 20, 2020
@ms-shankar ms-shankar self-assigned this Jan 20, 2020
@ms-shankar ms-shankar requested a review from aalhour January 20, 2020 15:41
@ms-shankar ms-shankar marked this pull request as ready for review January 20, 2020 15:42
@aalhour
Copy link
Contributor

aalhour commented Jan 27, 2020

Tested the Docker deployment and the Quick Start guide and it works like a charm! 🎉
I will begin testing the AWS deployment.

@ms-shankar
Copy link
Contributor Author

Hi, the unsupported variable write_aws_auth_config has now been removed in order to resolve build fails in AWS.

@aalhour
Copy link
Contributor

aalhour commented Feb 4, 2020

Re-tested the QuickStart Guide, it worked correctly! 🎉

➜ kaos build list
+-------+---------+----------+-------+
| index | context | provider |  env  |
+-------+---------+----------+-------+
|   0   |  DOCKER |  DOCKER  | local |
+-------+---------+----------+-------+

Re-tested the AWS deployment, it worked correctly! 🎉

➜ kaos build deploy -c AWS -e stage -vfy

Info - Endpoint successfully set to http://a846ef387473411eab3bc0240b6a2c25-1733664915.eu-west-1.elb.amazonaws.com:80/api/

Info - To interact with the Kubernetes cluster:
 export KUBECONFIG=/Users/ahmad/Workspace/kaos/kubeconfig_kaos-2-stage-eks-cluster
Info - Successfully built kaos [stage] environment

Build list command output:

➜ kaos build list

+-------+-----------+----------+-------+
| index |  context  | provider |  env  |
+-------+-----------+----------+-------+
|   0   |   DOCKER  |  DOCKER  | local |
+-------+-----------+----------+-------+
|   1   | AWS_stage |   AWS    | stage |
+-------+-----------+----------+-------+

kaos config contents:

➜ cat .kaos/config

[default]
user = ahmad
[contexts]
environments = DOCKER, AWS_stage
[active]
environment = AWS_stage
[DOCKER]
[[backend]]
url = http://localhost:80/api/
token = 5ef8b588-ddc5-455c-aeee-292e803d87c9
[[infrastructure]]
kubeconfig = ""
[pachyderm]
workspace = mnist
[AWS_stage]
[[backend]]
url = http://a846ef387473411eab3bc0240b6a2c25-1733664915.eu-west-1.elb.amazonaws.com:80/api/
token = fad68598-da77-4eea-9f27-bb66500ea29a
[[infrastructure]]
kubeconfig = ./kubeconfig_kaos-2-stage-eks-cluster

Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalhour aalhour merged commit 8ac1e00 into master Feb 4, 2020
@aalhour aalhour deleted the k-xxx-remove-state-file-validations branch February 4, 2020 10:00
aalhour added a commit to aalhour/kaos that referenced this pull request Oct 22, 2020
K-80: tf state file handling for multiple deployments (KI-labs#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollback broken build
2 participants